Add stretch variant for 1.13 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
approved these changes
Sep 5, 2019
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Sep 5, 2019
Changes: - docker-library/golang@151ac2e: Merge pull request docker-library/golang#300 from infosiftr/1.13-stretch - docker-library/golang@e7c5f60: Add stretch variant for 1.13 - docker-library/golang@1e0c17d: Update generated README
|
Thanks @tianon 🎉 ! I'm looking forward to the merge upstream into the official images. |
|
Oh! Guess I'm gonna use this while we fight out the issues with buster ❤️ |
7 tasks
leighmcculloch
added a commit
to stellar/go
that referenced
this pull request
Sep 20, 2019
Change the Debian version that the Go 1.13 checks, tests, and publishing occurs with to Debian Stretch, instead of Debian Buster. When we added tests for Go 1.13 the only image available on DockerHub was based on Debian Stretch. We made a case for publishing a Stretch version for at least a year while Stretch is still in use in docker-library/golang#296 and it was added in docker-library/golang/pull/300 and docker-library/official-images#6597. Since we're still using Debian Stretch we agreed it would be worthwhile to run our tests and builds on it until we upgrade. I left the postgresql fallback install code that pulls the deb from the official postgres apt repo when it's not available in the default system repo. That was also added for Buster because Buster doesn't have the version we need, version 9.6. I left that code there because we're likely to use it soon enough when we move everything to Buster anyway. Close #1718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leighmcculloch made a pretty compelling argument for this IMO 😄 😇
Closes #296